https://bugzilla.redhat.com/show_bug.cgi?id=1703284 --- Comment #8 from Xiubo Li <xiubli@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #7) > - License is LGPLv3+ or GPLv2 See > https://github.com/gluster/nbd-runner#license > > License: LGPLv3+ or GPLv2 > > Package approved. Please fix the aforementioned issue before import. > > > > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > ===== MUST items ===== > > C/C++: > [x]: Package does not contain kernel modules. > [x]: Package contains no static executables. > [x]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. > [x]: If your application is a C or C++ application you must list a > BuildRequires against gcc, gcc-c++ or clang. > [x]: Header files in -devel subpackage, if present. > [x]: Package does not contain any libtool archives (.la) > [x]: Rpath absent or only used for internal libs. > > Generic: > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "GPL (v2) (with incorrect FSF > address)", "Expat License Apache License (v2.0)", "Apache License > (v2.0)", "ISC License". 39 files have unknown license. Detailed output > of licensecheck in /home/bob/packaging/review/nbd-runner/review-nbd- > runner/licensecheck.txt @Robert-André Mauchin Thanks very much for you detail reply again, fixed the License and the using obsolete m4 macros issues. Update the srpm and spec: Spec URL: https://copr-be.cloud.fedoraproject.org/results/xiubli/nbd-runner/fedora-30-x86_64/00929528-nbd-runner/nbd-runner.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/xiubli/nbd-runner/fedora-30-x86_64/00929528-nbd-runner/nbd-runner-0.4-0.fc30.src.rpm # rpmlint nbd-runner-0.4-0.fc29.x86_64.rpm nbd-runner-debuginfo-0.4-0.fc29.x86_64.rpm nbd-runner-debugsource-0.4-0.fc29.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. # Thanks. BRs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
