https://bugzilla.redhat.com/show_bug.cgi?id=1709481 --- Comment #3 from Ondrej Soukup <osoukup@xxxxxxxxxx> --- Thank you very much for the review! (In reply to Robert-André Mauchin from comment #2) > - Source0 must be a url pointing to the archive > > Source0: > https://github.com/ctrlpvim/ctrlp.vim/archive/%{version}/%{name}-%{version}. > tar.gz I updated Source0 and also Source1 (hope I am not too eager) to URLs instead of file system paths. > - Version is 1.80, not 1.8.0 I corrected the version number. I have to admit that I was confused by the upstream since they use to use X.Y.Z versions but switched to X.YZ for some reason. You are right that I should respect their version notation. > - Appdata dir is the obsolete location, Appdata files now go in > %{_metainfodir} Directory for appdata files was also corrected according to your suggestion. > - Add vim-filesystem as a RR too > > Requires: vim-filesystem The requirements were updated also. The complete list of changes is at https://copr-dist-git.fedorainfracloud.org/cgit/osoukup/ctrlp.vim/vim-ctrlp.git/diff/vim-ctrlp.spec Additionally follows the links to updated COPR and KOJI builds https://copr.fedorainfracloud.org/coprs/osoukup/ctrlp.vim/build/929280/ https://koji.fedoraproject.org/koji/taskinfo?taskID=35450870 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
