[Bug 1713852] Review Request: asdcplib - AS-DCP file access libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1713852



--- Comment #6 from Simone Caronni <negativo17@xxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #5)
>  - We now forbid to glob the major soname version of a library to avoid
> unintentional soname bumps, be more precise instead:
> 
> %{_libdir}/*.so.2*

Fixed.

>  - Just use:
> 
> Source0:       
> https://github.com/cinecert/%{name}/archive/%{gittag}/%{name}-%{version}.tar.
> gz

Done.

>  - Why a libs subpackage? You could put the lib directly into the main
> package? asdcplib-libs is a bit redundant.

I would say mostly for consistency, but is fine, I removed the libs subpackage
and libraries are now in asdcplib.

Updates:

Spec URL: https://slaanesh.fedorapeople.org/asdcplib.spec
SRPM URL: https://slaanesh.fedorapeople.org/asdcplib-2.10.32-3.fc30.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux