[Bug 1416705] Review Request: python3-kivy - Kivy - Multimedia / Multitouch framework in Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1416705

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #23 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - These need to be added as Requires: they are needed when the package is
installed, not only at build time

# Unbundle fonts and JS
BuildRequires:  dejavu-sans-fonts
BuildRequires:  google-roboto-fonts
BuildRequires:  google-roboto-mono-fonts
BuildRequires:  js-underscore
BuildRequires:  js-jquery


 - Instead of making these executable, remove their shebang, you could do it in
%prep

# E: non-executable-script
chmod a+x %{buildroot}%{python3_sitearch}/kivy/tools/kviewer.py
chmod a+x %{buildroot}%{python3_sitearch}/kivy/tools/pep8checker/pep8.py
chmod a+x
%{buildroot}%{python3_sitearch}/kivy/tools/pep8checker/pre-commit.githook

 - Do this in %prep too:

# fixes E: script-without-shebang
chmod 0644 %{buildroot}%{_datadir}/kivy-examples/demo/kivycatalog/main.py
chmod 0644 %{buildroot}%{_datadir}/kivy-examples/demo/showcase/main.py
chmod 0644 %{buildroot}%{_datadir}/kivy-examples/demo/touchtracer/main.py
chmod 0644 %{buildroot}%{_datadir}/kivy-examples/demo/shadereditor/main.py
chmod 0644 %{buildroot}%{_datadir}/kivy-examples/demo/pictures/main.py
chmod 0644
%{buildroot}%{_datadir}/kivy-examples/demo/showcase/data/screens/"tabbedpanel +
layouts.kv"
chmod 0644 %{buildroot}%{_datadir}/kivy-examples/keyboard/android.txt
chmod 0644 %{buildroot}%{_datadir}/kivy-examples/keyboard/main.py
chmod 0644 %{buildroot}%{_datadir}/kivy-examples/keyboard/numeric.json
chmod 0644 %{buildroot}%{_datadir}/kivy-examples/settings/main.py

 - Why does the doc building needs xvfb-run?

xvfb-run make html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux