https://bugzilla.redhat.com/show_bug.cgi?id=1716729 --- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- We have %make_build and %make_install macros, you should us them instead of involving make directly (they should include the arguments you pass to them manually). I also recommend putting the Name before the Summary (the current order is not very common). %defattr(-,root,root,-) is no longer needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
