https://bugzilla.redhat.com/show_bug.cgi?id=1701013 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST --- Comment #21 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to Carl George from comment #20) > Package approved. > > There are a few other "should" items that can be cleaned up, but I don't > want to hold up the review any longer for them. Fix them at your leisure. > > * Enable the test suite in the future if you are able. I'll continue to check if it works on new releases but it doesn't appear to be compatible with the direct cmake build method. > * I don't see what your jobs macro is used for, and it's throwing a warning > for using define instead of global. Remove it if you can, or switch it to > global. That's left over from when I was using the setuptools method which didn't support -j. I can remove it. > * /usr/lib64/python3.7/site-packages/pyside2uic/icon_cache.py is throwing > some warnings due to it's shebang line. Strip that out if you can. If I new whether it was expected to be run directly I might just remove it, for now I can add it to the path fixes script. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
