Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome https://bugzilla.redhat.com/show_bug.cgi?id=291741 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-09-29 16:20 EST ------- This fails to build for me: checking for perl... /usr/bin/perl checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool error: Bad exit status from /var/tmp/rpm-tmp.78686 (%build) Just a missing build dependency on perl(XML::Parser); I added it and the build fails later: checking for python extension module directory... ${exec_prefix}/lib64/python2.5/site-packages Traceback (most recent call last): File "<string>", line 2, in <module> File "/usr/lib64/python2.5/distutils/sysconfig.py", line 497, in get_config_vars func() File "/usr/lib64/python2.5/distutils/sysconfig.py", line 356, in _init_posix raise DistutilsPlatformError(my_msg) distutils.errors.DistutilsPlatformError: invalid Python installation: unable to open /usr/lib64/python2.5/config/Makefile (No such file or directory) not found I added a build dependency on python-devel and the build fails later: file=`echo hu | sed 's,.*/,,'`.gmo \ && rm -f $file && -o $file hu.po /bin/sh: line 1: -o: command not found make[2]: *** [hu.gmo] Error 127 I added yet another build dependency, on gettext this time, and the build succeeds. If you already have build system access (which it seems you do since this bug isn't blocking FE-NEEDSPONSOR) then you can do a scratch build in koji with koji build --scratch dist-fc8 gnome-hearts-0.2-1.fc7.src.rpm or (if you have the system for it) you can install mock locally and test doing clean builds there; see http://fedoraproject.org/wiki/PackageMaintainers/MockTricks. Please be kind to the overworked reviewers and try to make sure your package builds properly in a clean buildroot before submitting it. Once building, there are some rpmlint warnings: gnome-hearts.x86_64: E: non-executable-script /usr/lib/python2.5/site-packages/gnome-hearts/players/pauline.py 0644 (and many like it) It seems to be a python habit to begin any file containing python code with the usual #! line even though the file is not intended to ever be run from the command line. Most of the time I ignore such complaints, but please check to make sure those files aren't ever to be run directly; if they are, then they should be executable. gnome-hearts.x86_64: E: explicit-lib-dependency libglade2 gnome-hearts.x86_64: E: explicit-lib-dependency libgnomeui You should not include Requires: lines for libraries which rpm will find on its own. gnome-hearts.x86_64: E: no-changelogname-tag Your %changelog is empty; you must include proper content there; see the Changelogs section of http://fedoraproject.org/wiki/Packaging/Guidelines gnome-hearts.x86_64: W: invalid-license GPL You must specify the proper GPL version; see http://fedoraproject.org/wiki/Licensing gnome-hearts.x86_64: E: invalid-desktopfile /usr/share/applications/gnome-hearts.desktop You're missing the required call to desktop-file-install in %install; it would then fail your build with an error: /tmp/gnome-hearts.desktop: error: file contains multiple assignments of key "Name" This is simply because the file has "Name=No name" and "Name=Hearts". Please see the "Desktop files" section of http://fedoraproject.org/wiki/Packaging/Guidelines for more information on the guidelines surrounding desktop files. Please do try running rpmlint on your packages (both the binary and source RPMs) before submission; it often times spews complaints which aren't relevant and it's OK to ask about those complaints in your review, but it gives you a chance to clean up the easy fixes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review