https://bugzilla.redhat.com/show_bug.cgi?id=1702720 Martin Osvald 🛹 <mosvald@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mruprich@redhat.c | |om) --- Comment #4 from Martin Osvald 🛹 <mosvald@xxxxxxxxxx> --- The below needs to be fixed: - the first three are related, more info in rpmlint section, the files there looks to be better candidate for -devel subpackage than -contrib as adding files only into /usr/share/doc even not documentation at all (scripts, relocatable files used during compilation (.o), and unstripped DSOs): [!] /usr/share/doc/frr-contrib/tools contains object/relocatable files [!] /usr/share/doc/frr-contrib/tools/.libs contains shared object files/DSOs [!]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 15 files. /usr/share/doc/frr-contrib consumes 912K [!] userdel && groupdel in %pre Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Texinfo files are installed using install-info in %post and %preun if package has .info files. Note: Texinfo .info file(s) in frr See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_texinfo - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/mosvald/Work/redhat/src/pkg-review/frr/review-frr/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in frr See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v2 or later)", "Expat License", "GPL (v2 or later) (with incorrect FSF address)", "ISC License GPL (v2 or later) (with incorrect FSF address)", "ISC License", "GPL (v3 or later)", "ISC License GPL (v2 or later)", "BSD 3-clause "New" or "Revised" License", "ISC License BSD 2-clause "Simplified" License", "BSD 2-clause "Simplified" License", "*No copyright* GPL (v2 or later)", "BSD (unspecified)", "GNU Lesser General Public License (v2.1 or later)", "GNU General Public License", "FSF Unlimited License (with Retention) GNU General Public License", "FSF Unlimited License (with Retention)", "GPL (with incorrect FSF address)", "*No copyright* Public domain", "*No copyright* GNU General Public License", "Expat License GPL (v2 or later)". 395 files have unknown license. Detailed output of licensecheck in /home/mosvald/Work/redhat/src/pkg- review/frr/review-frr/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/frr/modules, /usr/lib/frr, /usr/share/yang [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/logrotate.d, /usr/lib/frr, /usr/share/yang, /usr/lib64/frr/modules [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 15 files. /usr/share/doc/frr-contrib consumes 912K [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [-]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in frr [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [?]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: frr-7.0-1.fc31.x86_64.rpm frr-contrib-7.0-1.fc31.x86_64.rpm frr-devel-7.0-1.fc31.x86_64.rpm frr-debuginfo-7.0-1.fc31.x86_64.rpm frr-debugsource-7.0-1.fc31.x86_64.rpm frr-7.0-1.fc31.src.rpm frr.x86_64: E: description-line-too-long C FRRouting supports BGP4, OSPFv2, OSPFv3, ISIS, RIP, RIPng, PIM, NHRP, PBR, EIGRP and BFD. frr.x86_64: W: obsolete-not-provided frr-sysvinit frr.x86_64: W: obsolete-not-provided quagga frr.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/vtysh frr.x86_64: W: non-standard-uid /etc/frr frr frr.x86_64: W: non-standard-gid /etc/frr frr frr.x86_64: W: non-conffile-in-etc /etc/frr/daemons frr.x86_64: W: non-standard-uid /run/frr frr frr.x86_64: W: non-standard-gid /run/frr frr frr.x86_64: E: incorrect-fsf-address /usr/lib/frr/frr-reload.py frr.x86_64: W: non-standard-uid /var/log/frr frr frr.x86_64: W: non-standard-gid /var/log/frr frr frr.x86_64: W: dangerous-command-in-%pre userdel frr.x86_64: W: dangerous-command-in-%post chown frr-contrib.x86_64: E: arch-dependent-file-in-usr-share /usr/share/doc/frr-contrib/tools/.libs/gen_northbound_callbacks frr-contrib.x86_64: W: unstripped-binary-or-object /usr/share/doc/frr-contrib/tools/.libs/gen_northbound_callbacks frr-contrib.x86_64: W: binaryinfo-readelf-failed /usr/share/doc/frr-contrib/tools/.libs/gen_northbound_callbacks readelf: /tmp/rpmlint.frr-contrib-7.0-1.fc31.x86_64.rpm.iy21zrke/usr/share/doc/frr-contrib/tools/.libs/gen_northbound_callbacks: Error: No such file frr-contrib.x86_64: W: binaryinfo-tail-failed /usr/share/doc/frr-contrib/tools/.libs/gen_northbound_callbacks: [Errno 2] No such file or directory: '/tmp/rpmlint.frr-contrib-7.0-1.fc31.x86_64.rpm.iy21zrke/usr/share/doc/frr-contrib/tools/.libs/gen_northbound_callbacks' frr-contrib.x86_64: E: arch-dependent-file-in-usr-share /usr/share/doc/frr-contrib/tools/.libs/gen_yang_deviations frr-contrib.x86_64: W: unstripped-binary-or-object /usr/share/doc/frr-contrib/tools/.libs/gen_yang_deviations frr-contrib.x86_64: W: binaryinfo-readelf-failed /usr/share/doc/frr-contrib/tools/.libs/gen_yang_deviations readelf: /tmp/rpmlint.frr-contrib-7.0-1.fc31.x86_64.rpm.iy21zrke/usr/share/doc/frr-contrib/tools/.libs/gen_yang_deviations: Error: No such file frr-contrib.x86_64: W: binaryinfo-tail-failed /usr/share/doc/frr-contrib/tools/.libs/gen_yang_deviations: [Errno 2] No such file or directory: '/tmp/rpmlint.frr-contrib-7.0-1.fc31.x86_64.rpm.iy21zrke/usr/share/doc/frr-contrib/tools/.libs/gen_yang_deviations' frr-contrib.x86_64: E: arch-dependent-file-in-usr-share /usr/share/doc/frr-contrib/tools/.libs/permutations frr-contrib.x86_64: W: unstripped-binary-or-object /usr/share/doc/frr-contrib/tools/.libs/permutations frr-contrib.x86_64: W: binaryinfo-readelf-failed /usr/share/doc/frr-contrib/tools/.libs/permutations readelf: /tmp/rpmlint.frr-contrib-7.0-1.fc31.x86_64.rpm.iy21zrke/usr/share/doc/frr-contrib/tools/.libs/permutations: Error: No such file frr-contrib.x86_64: W: binaryinfo-tail-failed /usr/share/doc/frr-contrib/tools/.libs/permutations: [Errno 2] No such file or directory: '/tmp/rpmlint.frr-contrib-7.0-1.fc31.x86_64.rpm.iy21zrke/usr/share/doc/frr-contrib/tools/.libs/permutations' frr-contrib.x86_64: E: arch-dependent-file-in-usr-share /usr/share/doc/frr-contrib/tools/gen_northbound_callbacks.o frr-contrib.x86_64: E: arch-dependent-file-in-usr-share /usr/share/doc/frr-contrib/tools/gen_yang_deviations.o frr-contrib.x86_64: E: arch-dependent-file-in-usr-share /usr/share/doc/frr-contrib/tools/permutations.o frr-contrib.x86_64: E: arch-dependent-file-in-usr-share /usr/share/doc/frr-contrib/tools/ssd frr-contrib.x86_64: W: unstripped-binary-or-object /usr/share/doc/frr-contrib/tools/ssd frr-contrib.x86_64: W: binaryinfo-readelf-failed /usr/share/doc/frr-contrib/tools/ssd readelf: /tmp/rpmlint.frr-contrib-7.0-1.fc31.x86_64.rpm.iy21zrke/usr/share/doc/frr-contrib/tools/ssd: Error: No such file frr-contrib.x86_64: W: binaryinfo-tail-failed /usr/share/doc/frr-contrib/tools/ssd: [Errno 2] No such file or directory: '/tmp/rpmlint.frr-contrib-7.0-1.fc31.x86_64.rpm.iy21zrke/usr/share/doc/frr-contrib/tools/ssd' frr-contrib.x86_64: E: arch-dependent-file-in-usr-share /usr/share/doc/frr-contrib/tools/start-stop-daemon.o frr-contrib.x86_64: E: non-standard-dir-perm /usr/share/doc/frr-contrib/tools 644 frr-contrib.x86_64: W: hidden-file-or-dir /usr/share/doc/frr-contrib/tools/.deps frr-contrib.x86_64: E: non-standard-dir-perm /usr/share/doc/frr-contrib/tools/.deps 644 frr-contrib.x86_64: W: hidden-file-or-dir /usr/share/doc/frr-contrib/tools/.deps frr-contrib.x86_64: W: hidden-file-or-dir /usr/share/doc/frr-contrib/tools/.deps/.dirstamp frr-contrib.x86_64: E: zero-length /usr/share/doc/frr-contrib/tools/.deps/.dirstamp frr-contrib.x86_64: W: hidden-file-or-dir /usr/share/doc/frr-contrib/tools/.dirstamp frr-contrib.x86_64: E: zero-length /usr/share/doc/frr-contrib/tools/.dirstamp frr-contrib.x86_64: W: hidden-file-or-dir /usr/share/doc/frr-contrib/tools/.libs frr-contrib.x86_64: E: non-standard-dir-perm /usr/share/doc/frr-contrib/tools/.libs 644 frr-contrib.x86_64: W: hidden-file-or-dir /usr/share/doc/frr-contrib/tools/.libs frr-contrib.x86_64: E: non-standard-dir-perm /usr/share/doc/frr-contrib/tools/etc 644 frr-contrib.x86_64: E: non-standard-dir-perm /usr/share/doc/frr-contrib/tools/etc/frr 644 frr-contrib.x86_64: E: non-standard-dir-perm /usr/share/doc/frr-contrib/tools/etc/iproute2 644 frr-contrib.x86_64: E: non-standard-dir-perm /usr/share/doc/frr-contrib/tools/etc/iproute2/rt_protos.d 644 frr-contrib.x86_64: E: non-standard-dir-perm /usr/share/doc/frr-contrib/tools/etc/rsyslog.d 644 frr-devel.x86_64: W: only-non-binary-in-usr-lib frr-devel.x86_64: E: incorrect-fsf-address /usr/include/frr/ipaddr.h frr-devel.x86_64: E: incorrect-fsf-address /usr/include/frr/lua.h frr-devel.x86_64: E: incorrect-fsf-address /usr/include/frr/pbr.h frr-devel.x86_64: E: incorrect-fsf-address /usr/include/frr/sbuf.h frr-devel.x86_64: E: incorrect-fsf-address /usr/include/frr/version.h frr-devel.x86_64: E: incorrect-fsf-address /usr/include/frr/vlan.h frr-devel.x86_64: E: incorrect-fsf-address /usr/include/frr/vrf_int.h frr-devel.x86_64: E: incorrect-fsf-address /usr/include/frr/vxlan.h frr.src: E: description-line-too-long C FRRouting supports BGP4, OSPFv2, OSPFv3, ISIS, RIP, RIPng, PIM, NHRP, PBR, EIGRP and BFD. frr.src:6: E: hardcoded-library-path in /usr/lib/frr frr.src:33: W: unversioned-explicit-obsoletes frr-sysvinit frr.src:33: W: unversioned-explicit-obsoletes quagga frr.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5) 6 packages and 0 specfiles checked; 31 errors, 33 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
