Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qwt-doc The documentation for Qwt https://bugzilla.redhat.com/show_bug.cgi?id=243688 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |240180 OtherBugsDependingO|240180 | nThis| | ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-09-29 10:57 EST ------- For 5.0.2-1: * License/Source URL - Please change like qwt review - For Source0: ------------------------------------------- Source0 http://ovh.dl........ ------------------------------------------- This must be "Source0:" * Install at %build section ------------------------------------------- %build cd src qmake-qt4 sed -i "s\install_doc: first FORCE\install_doc: FORCE\1" Makefile make install_doc ------------------------------------------- - The last line does not seem to be needed. * Timestamp - As this package almost simply installs document files from tarball, keeping timestamp on those files is preferable. * For make install_doc, passing "COPY="cp -a", i.e. ------------------------------------------- make -f src/Makefile install_doc COPY="cp -a" ------------------------------------------- keeps timestamp on most files * And for "cp" or "install" command, please add "-p" option ------------------------------------------- cp -p %{SOURCE1} $RPM_BUILD_ROOT/%{_docdir}/qwt-%{version}/ ------------------------------------------- * Directory ownership - %_defaultdocdir/qwt-%{version} is not owned by this package * If you want to use this directory, this package needs "Requires: qwt = %{version}". * Or move all document files under %_defaultdocdir/qwt-doc-%{version} and have the directory owned by this package. * Macro in %changelog - %_dist tag is expanded differently when repository changes (for example, when we upgrade from fc8->fc9), then %changelog changes. %_dist macro should not be used in %changelog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review