https://bugzilla.redhat.com/show_bug.cgi?id=1714432 --- Comment #6 from Mark Goodwin <mgoodwin@xxxxxxxxxx> --- (In reply to Elliott Sales de Andrade from comment #5) > I tried to run fedora-review, but the tests fail: > [...] > /builddir/build/BUILD/cron-b41be1df696709bb6395fe435af20370037c0b4c/_build/ > src/github.com/robfig/cron/cron.go:199 +0x74b > --- FAIL: TestNonLocalTimezone (2.02s) > cron_test.go:261: expected job fires 2 times > FAIL > exit status 1 > FAIL github.com/robfig/cron 25.439s Hi Elliott, thanks once again. I ran fedora-review three times - the first failed (as you saw too), but then 2nd and 3rd runs passed. It seems the TestNonLocalTimezone / cron_test.go may be racy (in terms of how many times the job fires). I'll open an upstream issue about that. In the mean-time, I'll put this review request on hold - may be best to do anyway until v3.0.0 is tagged. Grafana can continue to vendor github.com/robfig/cron until then. Regards -- Mark -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
