Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: system-config-soundcard https://bugzilla.redhat.com/show_bug.cgi?id=226471 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2007-09-28 12:26 EST ------- rpmlint on SRPM and RPM is not clean ------------------------- system-config-soundcard.src:22: W: unversioned-explicit-obsoletes redhat-config-soundcard system-config-soundcard.src:31: W: prereq-use hicolor-icon-theme system-config-soundcard.src:160: W: macro-in-%changelog preun system-config-soundcard.src: E: no-cleaning-of-buildroot %install system-config-soundcard.src: W: invalid-license GPL system-config-soundcard.noarch: W: no-documentation system-config-soundcard.noarch: E: script-without-shebang /usr/share/system-config-soundcard/soundcardBackendKudzu.py system-config-soundcard.noarch: E: script-without-shebang /usr/share/system-config-soundcard/soundcardBackend.py system-config-soundcard.noarch: E: script-without-shebang /usr/share/system-config-soundcard/soundcardBackendHal.py system-config-soundcard.noarch: E: script-without-shebang /usr/share/system-config-soundcard/soundcardBackendSoundCard.py system-config-soundcard.noarch: E: script-without-shebang /usr/share/system-config-soundcard/soundcard.py system-config-soundcard.noarch: E: script-without-shebang /usr/share/system-config-soundcard/soundcardBackendProc.py system-config-soundcard.noarch: W: invalid-license GPL system-config-soundcard.noarch: W: obsolete-not-provided redhat-config-soundcard system-config-soundcard.noarch: W: conffile-without-noreplace-flag /etc/pam.d/system-config-soundcard system-config-soundcard.noarch: W: conffile-without-noreplace-flag /etc/security/console.apps/system-config-soundcard --------------------------------------------------------- also, 1) update buildroot tag as given in http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 2) packaging guidelines suggests use of make as http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e 3) missing buildroot cleanup in %install. check http://fedoraproject.org/wiki/Packaging/Guidelines#head-6c809b2e945ca78ae25d040f250be60f73181ef0 4) any reason for not using macros for following line om %files section /usr/bin/system-config-soundcard %dir /usr/share/system-config-soundcard /usr/share/system-config-soundcard/* 5) Any reason for commenting %doc COPYING? 6) good to use %defattr(-,root,root,-) Update package. Better to provide new SPEC and SRPM links for this package before actually committing in CVS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review