https://bugzilla.redhat.com/show_bug.cgi?id=1714377 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominik@xxxxxxxxxxxxxx --- Comment #5 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Please conditionalize the BuildRequires: needed for %check so that the package can be built without them. See https://src.fedoraproject.org/rpms/sbsigntools/blob/master/f/sbsigntools.spec for a simple example. In short, put %bcond_without check at the top and wrap %check-related BRs and the whole %check section with %if %{with check} / %endif. Another important point is to bump the Release: field and add a %changelog entry for each review iteration. Lastly, please see if you can run the tests in parallel, using something like (if necessary): PYTHONPATH=%{buildroot}%{python3_sitelib}:%{buildroot}%{python3_sitearch} \ pytest-%{python3_version} \ -v \ --disable-pytest-warnings \ --numprocesses=auto \ You might need to add python3-pytest-xdist to BRs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
