[Bug 1711898] Review Request: zeal - Offline documentation browser inspired by Dash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1711898



--- Comment #1 from Vasiliy Glazov <vascom2@xxxxxxxxx> ---
1. Remove BuildRequires:  qt5-qtbase.

2. Change cmake BR to cmake3 and %cmake macro to %cmake3.

3. As project use cmake for build it is better define BR as cmake(). For
example qt5-qtbase-devel provides "cmake(Qt5)" and can be changet to it.
BuildRequires:  cmake(Qt5)
Same for all other BRs that provide "cmake()" feature.

4. Remove DESTDIR=%{buildroot} because macro %make_install already contain it.

5. Change
%{_bindir}/zeal
%{_datadir}/icons/hicolor/*/apps/zeal.png
to
%{_bindir}/%{name}
%{_datadir}/icons/hicolor/*/apps/%{name}.png

This package still not retired. So may be you don't need review request.
Contact main maintainer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux