https://bugzilla.redhat.com/show_bug.cgi?id=1714511 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source addresses are Ok. Source0 archive (SHA-256: 6f0e3d494d77132b26ef3908a569e9b78797df6c22be82c202b4d171225b8f26) is original. Ok. Summary verified from lib/Sub/Attribute.pm. Ok. Description verified from lib/Sub/Attribute.pm. Ok. License verified from lib/Sub/Attribute.pm and ppport.h. Ok. Carp and MRO::Compat are not used. Ok. TODO: I recommend unsetting SUB_ATTRIBUTE_DEBUG environment variable in the %check section. Tests do pass with it. All test pass. Ok. $ rpmlint perl-Sub-Attribute.spec ../SRPMS/perl-Sub-Attribute-0.07-1.fc31.src.rpm ../RPMS/x86_64/perl-Sub-Attribute-* /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') 4 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -qlvp ../RPMS/x86_64/perl-Sub-Attribute-0.07-1.fc31.x86_64.rpm drwxr-xr-x 2 root root 0 May 28 12:26 /usr/lib/.build-id drwxr-xr-x 2 root root 0 May 28 12:26 /usr/lib/.build-id/94 lrwxrwxrwx 1 root root 71 May 28 12:26 /usr/lib/.build-id/94/b1d775424f9fae35399da28b388cc62a4277f6 -> ../../../../usr/lib64/perl5/vendor_perl/auto/Sub/Attribute/Attribute.so drwxr-xr-x 2 root root 0 May 28 12:26 /usr/lib64/perl5/vendor_perl/Sub -rw-r--r-- 1 root root 2148 Nov 1 2018 /usr/lib64/perl5/vendor_perl/Sub/Attribute.pm drwxr-xr-x 2 root root 0 May 28 12:26 /usr/lib64/perl5/vendor_perl/auto/Sub drwxr-xr-x 2 root root 0 May 28 12:26 /usr/lib64/perl5/vendor_perl/auto/Sub/Attribute -rwxr-xr-x 1 root root 25896 May 28 12:26 /usr/lib64/perl5/vendor_perl/auto/Sub/Attribute/Attribute.so drwxr-xr-x 2 root root 0 May 28 12:26 /usr/share/doc/perl-Sub-Attribute -rw-r--r-- 1 root root 1170 Nov 1 2018 /usr/share/doc/perl-Sub-Attribute/CHANGELOG -rw-r--r-- 1 root root 520 Jul 2 2017 /usr/share/doc/perl-Sub-Attribute/README drwxr-xr-x 2 root root 0 May 28 12:26 /usr/share/doc/perl-Sub-Attribute/example -rw-r--r-- 1 root root 312 May 28 12:26 /usr/share/doc/perl-Sub-Attribute/example/example_abstract.pl -rw-r--r-- 1 root root 366 May 28 12:26 /usr/share/doc/perl-Sub-Attribute/example/example_exporter.pl drwxr-xr-x 2 root root 0 May 28 12:26 /usr/share/doc/perl-Sub-Attribute/example/lib drwxr-xr-x 2 root root 0 Nov 1 2018 /usr/share/doc/perl-Sub-Attribute/example/lib/Attribute -rw-r--r-- 1 root root 510 Jul 2 2017 /usr/share/doc/perl-Sub-Attribute/example/lib/Attribute/Abstract.pm -rw-r--r-- 1 root root 1197 Jul 2 2017 /usr/share/doc/perl-Sub-Attribute/example/lib/Attribute/Exporter.pm -rw-r--r-- 1 root root 423 May 28 12:26 /usr/share/doc/perl-Sub-Attribute/example/loud.pl -rw-r--r-- 1 root root 773 May 28 12:26 /usr/share/doc/perl-Sub-Attribute/example/namespace.pl -rw-r--r-- 1 root root 2101 May 28 12:26 /usr/share/man/man3/Sub::Attribute.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Sub-Attribute-0.07-1.fc31.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.28()(64bit) 1 libpthread.so.0()(64bit) 1 perl(:MODULE_COMPAT_5.28.2) 1 perl(:VERSION) >= 5.8.0 1 perl(attributes) 1 perl(Exporter) 1 perl(parent) 1 perl(strict) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) TODO: Version perl(parent). $ rpm -q --provides -p ../RPMS/x86_64/perl-Sub-Attribute-0.07-1.fc31.x86_64.rpm | sort -f | uniq -c 1 perl(Sub::Attribute) = 0.07 1 perl-Sub-Attribute = 0.07-1.fc31 1 perl-Sub-Attribute(x86-64) = 0.07-1.fc31 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Sub-Attribute-0.07-1.fc31.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in F31 (https://koji.fedoraproject.org/koji/taskinfo?taskID=35106733). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please consider fixing the 'TODO' items before building this package. Resolution: APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
