Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: system-config-printer https://bugzilla.redhat.com/show_bug.cgi?id=226466 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2007-09-28 11:04 EST ------- picking up this for review. rpmlint output on SRPM and RPMs is not clean On SRPM it showed ------------------------------------ system-config-printer.src:30: W: prereq-use system-config-printer-libs = %{version}-%{release} The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. system-config-printer.src:44: W: prereq-use python The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. On RPM it showed ------------------------------------ system-config-printer.i386: I: checking system-config-printer.i386: W: non-conffile-in-etc /etc/security/console.apps/system-config-printer A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. system-config-printer.i386: W: non-conffile-in-etc /etc/xdg/autostart/redhat-print-applet.desktop A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. system-config-printer.i386: W: non-conffile-in-etc /etc/pam.d/system-config-printer A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. system-config-printer.i386: E: zero-length /usr/share/doc/system-config-printer-0.7.74.3/NEWS ===> You can drop this file. system-config-printer.i386: E: non-executable-script /usr/share/system-config-printer/cupsd.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. system-config-printer.i386: W: obsolete-not-provided system-config-printer-gui If a package is obsoleted by a compatible replacement, the obsoleted package must also be provided in order to provide clean upgrade paths and not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the provides. system-config-printer.i386: E: no-binary The package should be of the noarch architecture because it doesn't contain any binaries. ===> good to add following line in SPEC BuildArch: noarch system-config-printer.i386: W: dangerous-command-in-%post rm On -libs RPM it showed ----------------------------------- system-config-printer-libs.i386: I: checking system-config-printer-libs.i386: W: spurious-executable-perm /usr/share/doc/system-config-printer-libs-0.7.74.3/pycups-1.9.27/examples/cupstree.py The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. system-config-printer-libs.i386: W: non-conffile-in-etc /etc/dbus-1/system.d/newprinternotification.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. system-config-printer-libs.i386: E: non-executable-script /usr/share/system-config-printer/cupshelpers.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. system-config-printer-libs.i386: W: summary-ended-with-dot Common code for the graphical and non-graphical pieces. Summary ends with a dot. system-config-printer-libs.i386: W: doc-file-dependency /usr/share/doc/system-config-printer-libs-0.7.74.3/pycups-1.9.27/examples/cupstree.py /usr/bin/python An included file marked as %doc creates a possible additional dependency in the package. Usually, this is not wanted and may be caused by eg. example scripts with executable bits set included in the package's documentation. Also, 1) update buildroot tag to either of value given below %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) %{_tmppath}/%{name}-%{version}-%{release}-root 2) use %defattr(-,root,root,-) 3) preserve timestamps by using -p option eg. cp -p or install -p. Update package. Better to provide new SPEC and SRPM links for this package before actually committing in CVS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review