https://bugzilla.redhat.com/show_bug.cgi?id=1706548 --- Comment #3 from Guillaume Fayard <guillaume.fayard@xxxxxxxxxxx> --- Thanks for your comments! (In reply to Fabian Affolter from comment #1) > Just some comments to get started: > > - Docs are missing -> %doc README.md > - LICENSE is missing -> %license LICENSE > - Is "poetry>=0.12" provided by python3-dnfdaemon? > - .desktop file be included in the source as other distribution may need it > too > - Changelog entry is missing release > - There are translations (locales/fr/LC_MESSAGES). They should be included. Poetry is just a dev dependency. What do you mean by including locale files? Package has been updated: - SPEC: https://copr-be.cloud.fedoraproject.org/results/arkelis/simple-dnf/fedora-30-x86_64/00908268-simple-dnf/simple-dnf.spec - SRPM: https://copr-be.cloud.fedoraproject.org/results/arkelis/simple-dnf/fedora-30-x86_64/00908268-simple-dnf/simple-dnf-0.1.2-3.fc30.src.rpm > My biggest concern is that this package is a fork of https://github.com/hyakosm/simple_dnf. Yes it is a fork, but changes are meant to be merged into upstream (main maintainer is currently busy). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
