[Bug 1713767] Review Request: libnbd - NBD client library in userspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1713767



--- Comment #8 from Richard W.M. Jones <rjones@xxxxxxxxxx> ---
(In reply to Miro Hrončok from comment #6)
> It's a Python extension module that is called "lib..." and the RPM provides
> generator picks it up.
> You SHOULD filter it out, see
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> AutoProvidesAndRequiresFiltering/
> 
> Use something like (untested):
> 
> %global __requires_exclude_from ^%{python3_sitearch}/lib.*\\.so

Thanks for identifying this.  In the final package as it was built in Koji:

https://koji.fedoraproject.org/koji/taskinfo?taskID=35036199

I don't seem to see any "rogue" requires:

$ wget
https://kojipkgs.fedoraproject.org//work/tasks/6199/35036199/python3-libnbd-0.1-1.fc31.x86_64.rpm
$ rpm -qRp ./python3-libnbd-0.1-1.fc31.x86_64.rpm 
/usr/bin/sh
libc.so.6()(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libgnutls.so.30()(64bit)
libnbd(x86-64) = 0.1-1.fc31
libnbd.so.0()(64bit)
python(abi) = 3.7
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rtld(GNU_HASH)

I can add the exclude anyway.  Do you think the same could also apply to these
packages,
as they both have Python modules called lib<something>?

https://koji.fedoraproject.org/koji/buildinfo?buildID=1260105
https://koji.fedoraproject.org/koji/buildinfo?buildID=1235402

> > libnbd.src: W: strange-permission libnbd-0.1.tar.gz.sig 775
> > 
> >  - not sure about this one
> 
> I don't understand why a signature file has executable permissions.

> Please, don't. See https://pypi.org/project/nbd/

Heh, who knew :-)  OK we'll leave it as libnbd.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux