[Bug 1692166] Review Request: gnatcoll-db - The GNAT Components Collection – database packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1692166



--- Comment #5 from Richard W.M. Jones <rjones@xxxxxxxxxx> ---
rpmlint says:

gnatcoll-sql.x86_64: I: enchant-dictionary-not-found sv

 - fine, ignore

gnatcoll-sql.x86_64: W: no-documentation
gnatcoll-sqlite.x86_64: W: no-documentation
gnatcoll-postgres.x86_64: W: no-documentation
gnatcoll-xref.x86_64: W: no-documentation

 - adding %doc xref/README.md would fix all these

gnatcoll-xref.x86_64: W: spelling-error %description -l en_US ali -> ail, Ali,
tali
gnatcoll-xref.x86_64: W: spelling-error %description -l en_US gli -> glee,
glib, Eli

 - fine, ignore

gnatcoll-xref.x86_64: W: no-manual-page-for-binary gnatinspect
gnatcoll-db-devel.x86_64: W: no-manual-page-for-binary gnatcoll_all2ada
gnatcoll-db-devel.x86_64: W: no-manual-page-for-binary gnatcoll_db2ada

 - if one is available upstream it should be added, or you could write them;
however
   it's not a review blocker

gnatcoll-db-devel.x86_64: W: no-dependency-on
gnatcoll-db/gnatcoll-db-libs/libgnatcoll-db

 - however there is a correct dependency on the base package (gnatcoll-sql) and
other
   required packages, so this can be ignored

gnatcoll-db.src:83: W: unversioned-explicit-provides gnatinspect
gnatcoll-db.src:108: W: unversioned-explicit-provides gnatcoll_db2ada
gnatcoll-db.src:108: W: unversioned-explicit-provides gnatcoll_all2ada

 - this is a bug; the Provides lines should all have versions, ie:

     Provides: gnatinspect = %{version}-%{release}
     ...
     Provides: gnatcoll_db2ada = %{version}-%{release}
     Provides: gnatcoll_all2ada = %{version}-%{release}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux