https://bugzilla.redhat.com/show_bug.cgi?id=1712980 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@xxxxxxxxxx --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Just a quick glance at the spec file: Could you replace libslirp with %{name} in the URL tag? The same as you do in Source0? Since URL is a prefix of Source0 you can shorted Source0 with %{url} macro. The %files section uses globs for listing dynamic libraries. It is recommend to write down a soname explicitly <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files>. Please do so. The %ldconfig_scriptlets is not needed anymore. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
