Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qwt - Qt Widgets for Technical Applications https://bugzilla.redhat.com/show_bug.cgi?id=240180 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-09-28 05:32 EST ------- For 5.0.2-2: * Source URL - For sourceforge tarball, please follow: http://fedoraproject.org/wiki/Packaging/SourceURL * Group - IMO usually the main package has "System Environment/Libraries" and "Development/Libraries" is for -devel package. * License - License can be fine with 'LGPLv2 with exceptions' * Setup - %setup must be quiet (i.e. use '%setup -q') * parallel make - Support parallel make ('make %{?_smp_mflags}') if possible. Otherwise write as a comment that qwt does not support it. * %defattr - Now we recommend '%defattr(-,root,root,-)' * File entry - Some files are listed twice --------------------------------------------------- %{_includedir}/%{name}/* %{_includedir}/%{name} --------------------------------------------------- ! Note Say "foo" is a directory. Then if we write in %files entry --------------------------------------------------- %files %defattr(-,root,root,-) foo --------------------------------------------------- this means the directory "foo/" itself and all files/directories/etc under the directory foo/. * Documents - The tarball contains some files under doc/html/ and examples/. Would you consider to include some files from these directories (and create -doc subpackage), for example? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review