[Bug 1711303] Review Request: pass-pwned - Password-Store extension for Have I Been Pwned

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1711303



--- Comment #2 from Brian (bex) Exelbierd <bexelbie@xxxxxxxxxx> ---
Thank you for the review!

> [!]: Package requires other packages for directories it uses.
>     Note: No known owner of /usr/lib/password-store/extensions,
>     /usr/lib/password-store
>[!]: Package must own all directories that it creates.
>     Note: Directories without known owners: /usr/lib/password-store,
>     /usr/lib/password-store/extensions

I am following the pattern set in pass-otp.  I suspect these directories should
be owned an managed by pass, and not by a specific extension.  What do you
think?

>- rpmlint issues
> pass-pwned.noarch: W: only-non-binary-in-usr-lib
> pass-pwned.noarch: W: non-conffile-in-etc /etc/bash_completion.d/pass-pwned

These also appear with pass-otp and I wonder if they are caused by the nature
of this being a plugin. Specifically:

* The files in the extensions directory are valid shell scripts. This is the
expected location.  Pass did not provide a patch to move them to a different
place if that is what Fedora wants.
* The completions are partial files as they are loaded with the main completion
file.  

Any advice?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux