Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano13 - Library for manipulating panoramic images https://bugzilla.redhat.com/show_bug.cgi?id=253909 ------- Additional Comments From panemade@xxxxxxxxx 2007-09-28 03:00 EST ------- oops wrongly pasted above comment which should be in other package review which I did before. Now its your turn. here is your preliminary review. 1) Good to use following syntax in SPEC Requires: %{name} = %{version}-%{release} for -devel and -tools sub packages. 2) Use make %{?_smp_mflags} 3)Change %defattr(-,root,root) to %defattr(-,root,root,-) for all %files sections. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review