Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blitz : C++ class library for matrix scientific computing https://bugzilla.redhat.com/show_bug.cgi?id=246432 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED ------- Additional Comments From panemade@xxxxxxxxx 2007-09-28 02:45 EST ------- I will pick this for review. 1)do you need following files in -doc as rpmlint reported them as errors? blitz-doc.i386: E: zero-length /usr/share/doc/blitz-doc-0.9/html/classListInitializer__coll__graph.map blitz-doc.i386: E: zero-length /usr/share/doc/blitz-doc-0.9/html/classListInitializationSwitch__coll__graph.map blitz-doc.i386: E: zero-length /usr/share/doc/blitz-doc-0.9/html/classF__coll__graph.map blitz-doc.i386: E: zero-length /usr/share/doc/blitz-doc-0.9/html/minmax_8h__incl.map blitz-doc.i386: E: zero-length /usr/share/doc/blitz-doc-0.9/html/classReduceMaxIndexVector__coll__graph.png blitz-doc.i386: E: zero-length /usr/share/doc/blitz-doc-0.9/html/classVectorIterConst__coll__graph.map blitz-doc.i386: E: zero-length /usr/share/doc/blitz-doc-0.9/html/classVectorIter__coll__graph.map blitz-doc.i386: E: zero-length /usr/share/doc/blitz-doc-0.9/html/classIRNGWrapper_3_01IRNG_00_01sharedState_01_4__coll__graph.map blitz-doc.i386: E: zero-length /usr/share/doc/blitz-doc-0.9/html/classIRNGWrapper_3_01IRNG_00_01independentState_01_4__coll__graph.map blitz-doc.i386: E: zero-length /usr/share/doc/blitz-doc-0.9/html/wrap-climits_8h__incl.map blitz-doc.i386: E: zero-length /usr/share/doc/blitz-doc-0.9/html/classReduceMaxIndexVector__coll__graph.map 2) Change %defattr(-,root,root) to %defattr(-,root,root,-) for all %files sections. 3)Change preun section as suggested in http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-47896da5fb2662d75deefeb9ba75145a398515db 4) Add COPYING, README and LICENSE to all %doc lines in each %files sections 5) Good to have examples directory installed as part of -devel package Add examples to %doc of -devel 6) Remove following from SPEC Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig 7) Source URL should be Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz 8) Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). 9)Artistic 1.0 license is not valid now in Fedora. Upstream should move to Artistic 2.0 license -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review