https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #2 from Ryan Curtin <ryan@xxxxxxxxx> --- Hi Elliott, Thanks so much for your quick review. I handled each of the issues you pointed out and updated https://www.ratml.org/misc/ensmallen.spec and https://www.ratml.org/misc/ensmallen-1.14.2-1.fc30.src.rpm. > - The URL and Source look like they can use https://. Yeah, you're right, fixed. > - rm -rf $RPM_BUILD_ROOT should be removed Oops, didn't realize this was unnecessary. Gone now. > - You do not need to install LICENSE.txt manually; just list it as a relative path and it will be installed for you. Ah, nice! I didn't know that. Thanks. > - Summary should not end in a period. Fixed. > - If you've built the tests, why not run them in %check? Good point, they run in %check now. > - %changelog is missing version-release Oops, simple oversight. Fixed now. > - This fails to build for me due to missing armadillo; why is it not in BuildRequires also? (I don't think a new enough armadillo is packaged in Fedora, though.) Ah, yeah, you're right, Armadillo should be `BuildRequires` also. It is now, and the versions in Fedora should be new enough that it isn't a problem (6.500.0 or newer is necessary, and that was quite a while ago now). Let me know if you see any other issues and I'll get them handled. Thanks again! Ryan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
