[Bug 1701013] Review Request: python-pyside2 - Python bindings for the Qt 5 cross-platform application and UI framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1701013



--- Comment #11 from Richard Shaw <hobbes1069@xxxxxxxxx> ---
(In reply to Carl George from comment #9)
> 
> > I went ahead and added explicit requires on both shiboken2 and shiboken2-libs.
> 
> > Requires:       python3-shiboken2
> > Requires:       python3-shiboken2-libs
> 
> What provides python3-shiboken2?  I don't see that in the spec file, either
> as a subpackage or as a virtual provides.  Speaking of, why are
> python3-pyside2 and python3-shiboken2-libs not named similarly?  Both have
> similar contents, so at first glance it seem that python3-shiboken2-libs
> should just be named python3-shiboken2.  Let me know if I'm missing
> something here.

Whoops, fixed the first one to just shiboken2.

I was trying to mimic the original pyside packaging as much as possible, but I
could be convinced otherwise.


(In reply to Carl George from comment #10)
> > [ ]: License file installed when any subpackage combination is installed.
> 
> All the licenses are in the python3-pyside2 package, but installing other
> packages doesn't always pull it in as a dependency.  If the dependencies are
> correct, then the different subpackages should all own the license files.

Yeah, I dumped them in there initially. I'm going through the source files now
to see which is which.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux