https://bugzilla.redhat.com/show_bug.cgi?id=1707795 --- Comment #2 from Artem <ego.cordatus@xxxxxxxxx> --- Thank you for review. Fixed: Spec URL: https://atim.fedorapeople.org/for-review/nutty.spec SRPM URL: https://atim.fedorapeople.org/for-review/nutty-1.1.1-2.fc30.src.rpm > - Note: explicit /usr/bin/python3 is specific to Fedora-packaged software; > upstream may not want to do that. OK, now i finally understand because i asked many times about that should i send PR in such cases or not. > - License should be "GPLv3+ and ASL 2.0" (also comment that speedtest-cli is > ASL2.0) Fixed. > - The size@2 directories are not part of the hicolor-icon-theme, so this > package needs to own those directories. Or perhaps a bug needs to reported to > hicolor-icon-theme to add them. Fixed. Just removed them since they equal not regular and doesnt have HiDPI version for now. > - "mo" does not appear to be a valid language code (at least according to the > Wikipedia list of ISO-639-1 codes). The file doesn't appear to contain any > translations or any metadata for what language it's supposed to be, so I > think it's an error on upstream's part. This is most annoying part and often happens for me. But according this list https://en.wikipedia.org/wiki/ISO_3166-1 BH and MO files are there. So, maybe we should report about his in rpmlint checker tool? > - It appears you need to Requires:polkit for the /usr/share/polkit-1{,/actions} > directories. Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
