Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lybniz - A function graph plotter https://bugzilla.redhat.com/show_bug.cgi?id=308251 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-09-27 23:28 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 6cb01766fb627a5046d482645c69f39a lybniz-1.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Desktop file handled correctly. + Package lybniz-1.3-3.fc8 -> Requires: /bin/sh /usr/bin/python pygtk2 >= 2.6 python >= 2.4 + GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review