https://bugzilla.redhat.com/show_bug.cgi?id=1707532 --- Comment #1 from David Shea <dshea@xxxxxxxxxx> --- Created attachment 1565333 --> https://bugzilla.redhat.com/attachment.cgi?id=1565333&action=edit review.txt fedora-review output attached. Here's a summary of the problems: * COPYING should be listed as %license under %files, and needs to be at a minimum listed in the librpminspect and rpminspect-data-generic subpackages * /etc/rpminspect needs to be owned by rpminspect-data-generic * No need to "Requires: librpminspect" from rpminspect, rpmbuild picks up the .so requires * The "Requires: librpminspect = ..." in librpmsinspect-devel needs to be "Requires: librpminspect%{?_isa} = ..." * %defattr isn't needed anymore, that went away in RHEL-6 * use %make_build instead of %{__make} * librpminspect.so has an executable stack, which was probably my fault. Looking into it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
