[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1554022



--- Comment #9 from Stefan Koch <stefan.koch10@xxxxxxxxx> ---
Thank you for the good example. The build 895957 does not use hardcoded paths
anymore. Have you found one?
Commit:
https://github.com/kochstefan/usbauth-all/commit/76ee5774b0d8f1d1281720dba01db421a86f8f83

It uses within Makefile.am (as example):
usbauth_npriv_CFLAGS = -include config.h -DSBINDIR=\""$(sbindir)"\"
-DLIBEXECDIR=\""$(libexecdir)"\"

and .c source:
#define NOTIFIER_PATH LIBEXECDIR "/usbauth-notifier/usbauth-notifier"

This is described here:
"A corollary is that you should not use these variables except in makefiles.
For instance, instead of trying to evaluate datadir in configure and
hard-coding it in makefiles using e.g., ‘AC_DEFINE_UNQUOTED([DATADIR],
["$datadir"], [Data directory.])’, you should add -DDATADIR='$(datadir)' to
your makefile's definition of CPPFLAGS (AM_CPPFLAGS if you are also using
Automake)."
Soruce:
https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Installation-Directory-Variables.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux