Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pysol - A Python Solitaire game collection https://bugzilla.redhat.com/show_bug.cgi?id=304301 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-09-27 11:44 EST ------- Hmm, yes, that hack works. A few issues cropped up in testing, though: One, which I don't think is a blocker but is annoying, is that when you start pysol from the command line you get a bunch of spew: Error loading plugin /usr/share/pysol/games/acesup.py: duplicate game ID 903 Error loading plugin /usr/share/pysol/games/auldlangsyne.py: duplicate game ID 172 [etc...] I thought it was loading both the uncompiled and compiled versions of each file, but I deleted the .py[oc] files and it still happens. Another issue is that I can't pick many of the games; for example, Baker's Dozen just gives me a dialog (that I can't paste from, damn it) containing: Internal error. Please report this bug: <type 'exceptions.TypeError'>: unbound method startGame() must be called with CastlesInSpain instance as first argument (got BakersDozen instance instead) Perhaps it's related to the previous issue. There are also a couple of review issues: Source: tags should be URLs if possible. I don't see where pysol-4.82.tar.bz2 comes from, though; upstream only has the -src tarball. Where'd you get it? Might as well tack a period onto the end of %description. Review: ? can't check if source files match upstream. * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK (could use a period, I guess). * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: pysol = 4.82-5.fc8 = /bin/sh /usr/bin/env tcl tix tk tkinter X Manual testing shows many issues. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * desktop file looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review