https://bugzilla.redhat.com/show_bug.cgi?id=1703382 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Use %autosetup in build? Should the .pc file be also included? Should the package be called -headers or -devel? + package name is acceptable + license is acceptable for Fedora (MIT) + license is specified correctly + builds and installs OK + BR/R/P look OK Package is APPROVED. I think this looks OK, so I'll set the flag, but is the package really needed? Maybe it'd be easier and simpler and more effiecient to just copy those few files into the xorg-x11-drv-armada package? Are any other users likely? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx