https://bugzilla.redhat.com/show_bug.cgi?id=1670656 --- Comment #48 from Mark Goodwin <mgoodwin@xxxxxxxxxx> --- (In reply to Xavier Bachelot from comment #47) > (In reply to Mark Goodwin from comment #46) > > > > > There are %gotest and %gochecks macros that shall be used in %check. > > > https://fedoraproject.org/wiki/More_Go_packaging#.25check:_.25gochecks_and_.25.7Bgotest.7D > > > > now using %gochecks > > > The tests are not running anymore: > [...] > Testing: /builddir/build/BUILD/src/github.com/grafana/grafana/pkg > Path /builddir/build/BUILD/src/github.com/grafana/grafana/pkg not found on > /builddir/build/BUILD/grafana-6.1.4/_build > + exit 0 The docs say to simply use: %check %gochecks But that doesn't actually run any tests, successfully. So I have reverted to what I had previously: "go test ./pkg/..." until the issues in the go-rpm-integration script can be sorted out in rawhide (seems to be a path issue with _build or something). I also removed the last remaining rhel / fedora conditional stuff (e.g. for the distro version of config.ini). Spec URL: https://mgoodwin.fedorapeople.org/grafana/grafana.spec SRPM URL: https://mgoodwin.fedorapeople.org/grafana/grafana-6.1.4-1.fc31.src.rpm koji rawhide build: https://koji.fedoraproject.org/koji/taskinfo?taskID=34429399 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
