https://bugzilla.redhat.com/show_bug.cgi?id=1702634 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Url and Source0 addresses are usable. Ok. TODO: Please use canonical source path as is listed on MetaCPAN under the Download link: <https://cpan.metacpan.org/authors/id/S/SH/SHLOMIF/%{upstream_name}-%{version}.tar.gz>. Because a same-named distribution can be uploaded by multiple people to CPAN, it's important to have an author's name in the URL. Source0 archive (SHA-256: 1d91f0712c863b9655bba077844ac0bc1ec199663013a46fb7b060255a351d49) is original. Ok. FIX: Remove Group tag. It's obsolete in Fedora. Summary is Ok. Description verified from lib/Dir/Manifest.pm. OK. License verified from lib/Dir/Manifest/Slurp.pm, lib/Dir/Manifest/Key.pm, lib/Dir/Manifest.pm, Build.PL, LICENSE, and README. Ok. TODO: The '>= 0.280.0' version constraint at perl(Module::Build) won't do what you want because Fedora still does not normalize the module versions. The same applies to perl(Test::More) more dependency. You can remove them or format in a fractional notation. TODO: You can build-require 'perl(:VERSION) >= 5.14.0' (META.json:47). (This one is normalized.) TODO: You can use plain 'perl' command instead of %{__perl} macro. Otherwise build-requires are Ok. All tests pass. Ok. $ rpmlint perl-Dir-Manifest.spec ../SRPMS/perl-Dir-Manifest-0.0.3-1.fc31.src.rpm ../RPMS/noarch/perl-Dir-Manifest-0.0.3-1.fc31.noarch.rpm /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') perl-Dir-Manifest.src: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments perl-Dir-Manifest.src: W: spelling-error %description -l en_US txt -> text, ext, tit perl-Dir-Manifest.src: W: spelling-error %description -l en_US lf -> fl, lg, l /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') perl-Dir-Manifest.noarch: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments perl-Dir-Manifest.noarch: W: spelling-error %description -l en_US txt -> text, ext, tit perl-Dir-Manifest.noarch: W: spelling-error %description -l en_US lf -> fl, lg, l 2 packages and 1 specfiles checked; 0 errors, 6 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Dir-Manifest-0.0.3-1.fc31.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.2) 1 perl(:VERSION) >= 5.14.0 1 perl(Dir::Manifest::Key) 1 perl(Dir::Manifest::Slurp) 1 perl(Exporter) 1 perl(Moo) 1 perl(parent) 1 perl(Path::Tiny) 1 perl(Socket) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Dir-Manifest-0.0.3-1.fc31.noarch.rpm | sort -f | uniq -c 1 perl(Dir::Manifest) = 0.0.3 1 perl(Dir::Manifest::Key) = 0.0.3 1 perl(Dir::Manifest::Slurp) = 0.0.3 1 perl-Dir-Manifest = 0.0.3-1.fc31 Binary provides are Ok. Package builds in F31 (https://koji.fedoraproject.org/koji/taskinfo?taskID=34388641). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the 'FIX' item and consider fixing 'TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
