https://bugzilla.redhat.com/show_bug.cgi?id=1699846 Martin Osvald 🛹 <mosvald@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tkorbar@xxxxxxxxx | |m) --- Comment #3 from Martin Osvald 🛹 <mosvald@xxxxxxxxxx> --- What needs to be looked further into (evaluated)... In short the most important stuff to me: 1. Remove ldconfig scriptlets as they are not needed since and including F28. Besides there is a duplication of the same thing %ldconfig_scriptlets does the same thing as the lines 103 & 104: ~~~ 101 %ldconfig_scriptlets 102 103 %post -n libyang-cpp -p /sbin/ldconfig 104 %postun -n libyang-cpp -p /sbin/ldconfig ~~~ 2. Change libyang-devel-doc from x86_64 to noarch 3. Add python_provide macro The below is cherry-picked list from comment 2: Issues: ======= ------------------------------------------------------------ - ldconfig not called in %post and %postun for Fedora 28 and later. Note: /sbin/ldconfig called in libyang-cpp See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets ------------------------------------------------------------ ===== MUST items ===== ------------------------------------------------------------ [!]: Spec file is legible and written in American English. - libyang.x86_64: W: spelling-error %description -l en_US modelling -> modeling, model ling, model-ling ------------------------------------------------------------ ------------------------------------------------------------ [!]: Package meets the Packaging Guidelines::Python - XXX NOTE: Not a python expert, but shouldn't spec file contain python_provide macro if it provides python module? https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro e.g something like the below? ~~~ %global srcname libyang %package -n python3-%{srcname} Summary: Python3 bindings for libyang Requires: libyang-cpp%{?_isa} = %{version}-%{release} Requires: %{name}%{?_isa} = %{version}-%{release} %{?python_provide:%python_provide python3-%{srcname}} ~~~ ------------------------------------------------------------ ===== SHOULD items ===== ------------------------------------------------------------ Generic: [!]: Uses parallel make %{?_smp_mflags} macro. ------------------------------------------------------------ ===== EXTRA items ===== ------------------------------------------------------------ Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 11233280 bytes in /usr/share libyang-devel-doc-0.16.105-1.fc31.x86_64.rpm:11212800 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines ------------------------------------------------------------ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
