https://bugzilla.redhat.com/show_bug.cgi?id=1701810 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-256: d0082f5df955f1e720f1f221d07ac8f1b38640444a2f410d46a1e607f4fbd89e) is original. Ok. Summary is Ok. Description is Ok. TODO: Capitalize "perl" as "Perl" in the description text. "perl" denotes /usr/bin/perl program while "Perl" denotes a programing language. License verified from README and Makefile.PL files. Ok. No XS code found, noarch BuildArch is Ok. FIX: Do not use %makeinstall macro. It's forbidden. Use %make_install instead. TODO: If you constrain 'BuildRequires: perl(ExtUtils::MakeMaker)' with '>= 6.77', and append 'NO_PACKLIST=1 NOPERLLOCAL=1' to 'perl Makefile.PL' command, you can use recommended %make_build instead of 'make %{?_smp_mflags}' and you cane remove the 'find' command from %install section. FIX: Package README using %doc macro. It's the only file that declares a license. TODO: Constrain perl(Scalar::Util) dependency with '>= 1.01 (Makefile.PL:16). FIX: Build-require perl(File::Find) (t/01-pod.t:3). FIX: Build-require perl(File::Spec) (t/01-pod.t:2). FIX: Remove a dependency on perl(Test::Harness). It's nowhere used. TODO: Do not build-require perl(Test::Signature) and preferably remove t/00-Signature.t file. First it's pointless checking a signature after the signed code had already been executed. Second if Fedora needs patching the code, the signature will become invalid, third there is no public key preloaded and thus the signature cannot be validated. Fourth, the test fails for me even now. FIX: Tests do not pass: + make test PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00-Signature.t ...... Old SIGNATURE detected. Please inform the module author to regenerate SIGNATURE using Module::Signature version 0.82 or newer. gpg: WARNING: unsafe permissions on homedir '/home/test/.gnupg' gpg: WARNING: unsafe permissions on homedir '/home/test/.gnupg' WARNING: This key is not certified with a trusted signature! Primary key fingerprint: BD2B 7528 2941 2518 0F94 543A A57B F5B2 9322 96DD Not in MANIFEST: debugfiles.list Not in MANIFEST: debuglinks.list Not in MANIFEST: debugsourcefiles.list Not in MANIFEST: debugsources.list Not in MANIFEST: elfbins.list ==> MISMATCHED content between MANIFEST and distribution files! <== t/00-Signature.t ...... 1/1 # Failed test 'Valid signature' # at t/00-Signature.t line 13. # Looks like you failed 1 test of 1. t/00-Signature.t ...... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Please correct all the 'FIX' items, consider fixing 'TODO' items and provide an updated spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
