[Bug 1701013] Review Request: python-pyside2 - Python bindings for the Qt 5 cross-platform application and UI framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1701013



--- Comment #6 from Richard Shaw <hobbes1069@xxxxxxxxx> ---
(In reply to Carl George from comment #4)
> 
> Can you adjust your globs in %files to be more specific?  Perhaps something
> like:
> 
> -%{_libdir}/libpyside2*.so.*
> +%{_libdir}/libpyside2*.so.5.12*
> 
> -%{_libdir}/libshiboken2*.so.*
> +%{_libdir}/libshiboken2*.so.5.12*
> 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_listing_shared_library_files

Done.


> I also agree with Miro's previous point about filtering the autoprovides
> (bug 1634658, comment 90).  I checked a few other arched python modules, and
> none of them provide their sonames from within %{python3_sitearch}.
> 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> AutoProvidesAndRequiresFiltering/#_summary
> 
> > Packages must not provide RPM dependency information when that information is not global in nature
> 
> Since libpyside2.cpython-37m-x86_64-linux-gnu.so.5.12 and
> libshiboken2.cpython-37m-x86_64-linux-gnu.so.5.12 are not global in nature I
> think they should be filtered out.  As further evidence of this, rpmlint
> expects python3-shiboken2-devel to explicitly require python3-shiboken2-libs.

The files are actually installed to %{_libdir} not %{python3_sitearch} so per
the conversation in the devel mailing list I think I'm going to leave them be.


> > python3-shiboken2-devel.x86_64: W: no-dependency-on python3-shiboken2/python3-shiboken2-libs/libpython3-shiboken2
> 
> I would filter out the automatic libshiboken2 provides/requires and
> explicitly require the necessary packages.

I went ahead and added explicit requires on both shiboken2 and shiboken2-libs.

I'm going to do a test build first and then I'll post new links.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux