https://bugzilla.redhat.com/show_bug.cgi?id=1658153 --- Comment #87 from Petr Menšík <pemensik@xxxxxxxxxx> --- Note there is issue with examples directory ownership. Add into %files opengl-examples: %dir %{_datadir}/white_dune/ %dir %{_datadir}/white_dune/opengl_example/ Or change it to: %files opengl-examples %{_bindir}/white_dune_opengl_example %dir %{_datadir}/white_dune %{_datadir}/white_dune/opengl_example More about it on [1]. Not really sure whether update-desktop-database in %post is still required. On page it links it is not even mentioned. Have to ask for that on devel list. But checked just now, original tarball contains lib/textures with some textures. Is not such data packaged at all? Is there reason for it? I think noarch package might be useful for them, possibly recommended by wdune package. Could be useful for first creations I think. Not mandatory for passing review however. (In reply to J. Scheurich from comment #84) > white_dune reaches version 1, but full function would require the ffmpeg > libraries for MovieTexture rendering. > The ffmpeg libraries are not available on Fedora, so a harmless warning in > configure is thrown. Well, yes, this is unfortunate, but could not be easily solved. If it used something with decoder plugins such as Gstreamer instead, it could include support at least for video codecs that can be shipped in Fedora. Other decoders could be installed from non-fedora sources if law permits that. I think MPEG 1 and 2 are now allowed in Fedora, but FFMPEG as whole is still not acceptable. I doubt that can be improved soon. 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
