Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lybniz - A function graph plotter https://bugzilla.redhat.com/show_bug.cgi?id=308251 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2007-09-27 00:08 EST ------- Need some updates in SPEC 1) Source URL should be http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz 2) You can use --delete-original in desktop-file-install command and remove following line rm -f ${RPM_BUILD_ROOT}%{_datadir}/applications/%{name}.desktop 3)rpmlint on SRPM gave me lybniz.src: W: strange-permission lybniz-startup.sh 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. 4) I don't see any use of CFLAGS. You can remove it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review