https://bugzilla.redhat.com/show_bug.cgi?id=1701070 --- Comment #6 from Honggang LI <honli@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #5) > - Should work > > https://github.com/linux-rdma/ibsim/archive/%{version}/%{name}-%{version}. > tar.gz > Done. > > - Should work too, it is strictly equivalent to the one you were using: > > %make_install prefix=%{_prefix} libpath=%{_libdir} binpath=%{_bindir} > > (I forgot a _ previously) Confirmed this works. Done. > > (In reply to Honggang LI from comment #3) > > (In reply to Robert-André Mauchin from comment #1) > > > - You include patches but they are not applied > > > > 0001-umad2sim-Do-not-use-umad.h-deprecated-functions.patch > > 0002-run_opensm.sh-remove-opensm-c-option.patch > > > > Patch #0001 applied in upstream repo. It was generated from upstream repo. > > Patch #0002 is under reviewing, see > > https://patchwork.kernel.org/patch/10746335/ > > > > #0002 is necessary, because opensm will exit after dump the default > > configuration. > > After remove the '-c' parameter, you can run opensm with ibsim without any > > extra parameters. > > > > Add these comments to the SPEC itself, a third party needs to be able to > understand what are these for, also if they are upstreamed. Done. > Package approved. Please fix the aforementioned issue before import. diff -Nurp ibsim.spec.v2 ibsim.spec --- ibsim.spec.v2 2019-04-22 09:07:32.048976920 -0400 +++ ibsim.spec 2019-04-22 09:24:02.245335766 -0400 @@ -3,8 +3,10 @@ Name: ibsim Version: 0.8 Release: 1%{?dist} License: GPLv2 or BSD -Source: https://github.com/linux-rdma/ibsim/releases/download/0.8/ibsim-0.8.tar.gz +Source: https://github.com/linux-rdma/%{name}/releases/download/%{version}/%{name}-%{version}.tar.gz +# Patch #0001 applied in upstream repo. It was generated from upstream repo. Patch1: 0001-umad2sim-Do-not-use-umad.h-deprecated-functions.patch +# Patch #0002 is under reviewing. https://patchwork.kernel.org/patch/10746335/ Patch2: 0002-run_opensm.sh-remove-opensm-c-option.patch Url: https://github.com/linux-rdma/ibsim @@ -22,7 +24,7 @@ OFA OpenSM, diagnostic and management to %make_build %install -make DESTDIR=${RPM_BUILD_ROOT} prefix=%_prefix libpath=%_libdir binpath=%_bindir install +%make_install prefix=%{_prefix} libpath=%{_libdir} binpath=%{_bindir} %files %{_libdir}/umad2sim/ @@ -31,3 +33,5 @@ make DESTDIR=${RPM_BUILD_ROOT} prefix=%_ %license COPYING %changelog +* Mon Apr 22 2019 Honggang Li <honli@xxxxxxxxxx> - 0.8-1 +- Import ibsim for fedora I uploaded updated spec and srpm to the http server: Spec URL: http://people.redhat.com/honli/ibsim/ibsim.spec SRPM URL: http://people.redhat.com/honli/ibsim/ibsim-0.8-1.fc31.src.rpm I will request a git repository for ibsim. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
