Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libgssglue - renaming libgssapi to libgssglue https://bugzilla.redhat.com/show_bug.cgi?id=286691 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-09-26 23:40 EST ------- Fine. Though I am not happy with "not updating SPEC changelog and providing new SRPM each time SPEC got some noticeable changes", as per your wish I am approving this package here. You should have added at least review bug number in changelog if you preferred not to update release. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. ce1b4c758e6de01b712d154c5c97e540 libgssglue-0.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + libgssglue.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + Package libgssglue-0.1-2.fc8 -> Provides: config(libgssglue) = 0.1-2.fc8 libgssglue.so.1 libgssglue.so.1(HIDDEN) libgssglue.so.1(libgssapi_CITI_2) Requires: config(libgssglue) = 0.1-2.fc8 krb5-libs >= 1.5 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdl.so.2 libdl.so.2(GLIBC_2.0) libdl.so.2(GLIBC_2.1) libgssglue.so.1 rtld(GNU_HASH) Package libgssglue-devel-0.1-2.fc8 -> Requires: libgssglue = 0.1-2.fc8 libgssglue.so.1 pkgconfig + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review