https://bugzilla.redhat.com/show_bug.cgi?id=1701070 --- Comment #3 from Honggang LI <honli@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) > - You include patches but they are not applied 0001-umad2sim-Do-not-use-umad.h-deprecated-functions.patch 0002-run_opensm.sh-remove-opensm-c-option.patch Patch #0001 applied in upstream repo. It was generated from upstream repo. Patch #0002 is under reviewing, see https://patchwork.kernel.org/patch/10746335/ #0002 is necessary, because opensm will exit after dump the default configuration. After remove the '-c' parameter, you can run opensm with ibsim without any extra parameters. > %setup -q → %autosetup -p1 will apply them Yes, applied. -%setup -q +%autosetup -v -p1 > > - %build > export CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" > export LDFLAGS="${LDFLAGS:-${RPM_OPT_FLAGS}}" > > Use %set_build_flags instead > > - make %{?_smp_mflags} → %make_build Yes, applied. %build -export CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" -export LDFLAGS="${LDFLAGS:-${RPM_OPT_FLAGS}}" -make %{?_smp_mflags} +%set_build_flags +%make_build > - make DESTDIR=${RPM_BUILD_ROOT} prefix=%_prefix libpath=%_libdir > binpath=%_bindir install > > → > > %make install prefix=%{_prefix} libpath=%{_libdir} binpath=%{_bindir} No, because rpm building failed with this change. > - Add your own %changelog entry > > %changelog > * Sun Apr 21 2019 Honggang LI <honli@xxxxxxxxxx> - 0.8-1 > - Initial package I see, but I want to add such %changelog entry in last minute. I will add that when this package get fedora review approve. > - Use macros here: > > Source: > https://github.com/linux-rdma/ibsim/releases/download/%{version}/%{name}- > %{version}.tar.gz Well, I see. But the problem is that. Not all tarball released in github has consistent URL format. Let's take ibsim as an example: https://github.com/linux-rdma/ibsim/archive/ibsim-0.6.tar.gz https://github.com/linux-rdma/ibsim/archive/ibsim-0.7.tar.gz https://github.com/linux-rdma/ibsim/releases/download/0.8/ibsim-0.8.tar.gz As you see, URL format changed. I noticed a few packages have outdated SOURCE tag, because the URL format changed. That is why I use the hardcoded URL for ibsim. Anyway, I can change the URL, if you want. > - Please include comments above each of the patch to explain why they are > needed. Please see previous comment. > > > > It seems there is a problem in Rawhide with a dependency: > > DEBUG util.py:556: Last metadata expiration check: 0:00:02 ago on Sun Apr > 21 08:26:35 2019. > DEBUG util.py:554: BUILDSTDERR: Error: > DEBUG util.py:554: BUILDSTDERR: Problem: package > infiniband-diags-devel-2.1.0-2.fc30.x86_64 requires libibmad.so.5()(64bit), > but none of the providers can be installed > DEBUG util.py:554: BUILDSTDERR: - package > infiniband-diags-devel-2.1.0-2.fc30.x86_64 requires > libibnetdisc.so.5()(64bit), but none of the providers can be installed > DEBUG util.py:554: BUILDSTDERR: - package > infiniband-diags-devel-2.1.0-2.fc30.x86_64 requires infiniband-diags(x86-64) > = 2.1.0-2.fc30, but none of the providers can be installed > DEBUG util.py:554: BUILDSTDERR: - conflicting requests > DEBUG util.py:554: BUILDSTDERR: - nothing provides > libosmcomp.so.4()(64bit) needed by infiniband-diags-2.1.0-2.fc30.x86_64 > DEBUG util.py:554: BUILDSTDERR: - nothing provides > libosmcomp.so.4(OSMCOMP_2.3)(64bit) needed by > infiniband-diags-2.1.0-2.fc30.x86_64 > > > > It seems *you* did an oopsie here: you updated > https://src.fedoraproject.org/rpms/opensm to 3.3.22 and that include a > soname bump from 4 to 5, which you should have announced to the devel > mailing list, and rebuild all the dependant packages, including > infiniband-diags. Well, I sent a notice to the devel mailing list. I also rebuilt infiniband-diags-2.1.0-3.fc31 against the latest opensm-3.3.22 for rawhide. But it seems need sometime for infiniband-diags-2.1.0-3.fc31 to get in fedora rawhide repo. I uploaded updated spec and srpm to the http server: Spec URL: http://people.redhat.com/honli/ibsim/ibsim.spec SRPM URL: http://people.redhat.com/honli/ibsim/ibsim-0.8-1.fc31.src.rpm > To avoid such situation we now forbid globbing the major soname version in > libraries: > > %files libs > %{_libdir}/lib*.so.* ← forbidden now thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
