[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1665749



--- Comment #17 from Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #16)
> > for lib in %{python_sitelib}/${srcname}/*.py; do ...
> 
> You probably need to move this section to the end of %install.
> ${srcname} → %{srcname}
> %{python_sitelib} → %{buildroot}%{python2_sitelib}
> 
> > install -p build/man/pipreqs.1 -Dt %buildroot/%_mandir/man1/
> 
> install -Dm0644 -p build/man/pipreqs.1 -Dt %buildroot/%_mandir/man1/

Thanks for the help! :)

I've pushed the latest changes. Please take a look and let me know.

Unfortunately, my 'fedora-review' does not work due to some issues with 'mock'.
As a result, I can't verify if the changes did work out well. Koji builds
complete successfully though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux