https://bugzilla.redhat.com/show_bug.cgi?id=1700438 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Not needed: rm -rf %{buildroot} - No, you don't have access to Internet in mock/koji, this will never work: # Get go dependencies go get -u github.com/kardianos/govendor go install github.com/kardianos/govendor Instead package the deps first then BR them: BuildRequires: golang(import path) - You should use the Go macros loosely defined in https://fedoraproject.org/wiki/More_Go_packaging Note that we are in the process of rewriting them for F31 (https://eclipseo.fedorapeople.org/guidelines/packaging-guidelines/Golang/ ) # Generated by go2rpm %bcond_without check # https://github.com/mikefarah/yq %global goipath github.com/mikefarah/yq Version: 2.3.0 %gometa %global common_description %{expand: Yq is a portable command-line yaml processor.} Name: yq Release: 1%{?dist} Summary: Portable command-line yaml processor License: MIT URL: %{gourl} Source0: %{gosource} BuildRequires: golang(github.com/pkg/errors) BuildRequires: golang(gopkg.in/imdario/mergo.v0) BuildRequires: golang(gopkg.in/mikefarah/yaml.v2) BuildRequires: golang(gopkg.in/op/go-logging.v1) BuildRequires: golang(gopkg.in/spf13/cobra.v0) %description %{common_description} %package devel Summary: %{summary} BuildArch: noarch %description devel %{common_description} This package contains library source intended for building other packages which use import path with %{goipath} prefix. %prep %forgeautosetup -p1 %build %gobuildroot %gobuild -o _bin/yq %{goipath} %install %goinstall install -m 0755 -vd %{buildroot}%{_bindir} install -m 0755 -vp _bin/* %{buildroot}%{_bindir}/ %if %{with check} %check %gochecks %endif %files %license LICENSE %doc docs examples README.md %{_bindir}/* %changelog * Mon Mar 25 2019 Bradford Dabbs <brad@xxxxxxxxxx> - 2.3.0-1 - Initial package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
