https://bugzilla.redhat.com/show_bug.cgi?id=1663090 --- Comment #6 from Michael Schwendt <bugs.michael@xxxxxxx> --- Additional hints: > SRPM URL: https://copr.fedorainfracloud.org/coprs/trusty/direvent/build/841501/ Please link valid src.rpm packages, not service pages which lead to 404 not found or which are a maze. > https://copr-be.cloud.fedoraproject.org/results/trusty/direvent/epel-7-x86_64/00841271-direvent/build.log.gz configure check reports various "no" items, not limited to flex, bison, gettext et al. These should be revisited, since BuildRequires may be needed. > BuildRequires: glibc glibc-devel actually. Also needed is "BuildRequires: gcc". https://fedoraproject.org/wiki/Changes/Remove_GCC_from_BuildRoot > make[4]: Entering directory `/builddir/build/BUILD/direvent-5.1/grecs/src' > CC asprintf.o No verbose compiler output means one cannot see any compiler/linker options. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags See what's necessary to make the output verbose, such as removing silent flags or calling "V=1 make". Also notice: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make > %check > make check > > %install > %make_install Technically, %check is execute after %install, so the order of the spec file sections should match that. Btw, often enough, the %check section will be used to perform tests within the %buildroot, and for that %install would have to be done. > %doc %{_datadir}/info/dir > %doc %{_datadir}/man/man5/direvent.conf.5* > %doc %{_datadir}/man/man8/direvent.8* https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros If you absolutely want to rely on macros, prefer %{_infodir} and %{_mandir} here. Further, many such paths are implicitly marked as %doc, so it's not necessary to add the %doc prefix. $ rpm -E %__docdir_path /usr/share/doc:/usr/share/man:/usr/share/info:/usr/share/gtk-doc/html::/usr/share/man:/usr/share/info:/usr/share/javadoc:/usr/doc:/usr/man:/usr/info:/usr/X11R6/man -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
