[Bug 1701013] Review Request: python-pyside2 - Python bindings for the Qt 5 cross-platform application and UI framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1701013



--- Comment #2 from Richard Shaw <hobbes1069@xxxxxxxxx> ---
(In reply to Miro Hrončok from comment #1)
> > Requires:       pytside2-tools
> 
> typo

Fixed.


> > %package -n     python3-%{pypi_name}-devel
> 
> For consistency, this should provide camel_name + do %python_provide as well.
> Other subpackages don't %python_provide either.

Wasn't sure exactly what you meant so I added both python_provides just like
the main module.


> > # Fix all Python shebangs recursively in .
> 
> This is copy-pasted, but the . part is no longer true.
> 
> > pathfix.py -pni "%{__python3} %{py3_shbang_opts}" %{buildroot}%{_bindir}/*.py
> > pathfix.py -pni "%{__python3} %{py3_shbang_opts}" %{buildroot}%{_bindir}/pyside2-uic
> 
> Just do: pathfix.py -pni "%{__python3} %{py3_shbang_opts}"
> %{buildroot}%{_bindir}/*
> It will be future proof.

Fixed.


> > # Lots of tests fail currently...
> > #{__python3} testrunner.py test
> 
> If I decide to check this, how long does the package build? Will it eat all
> my RAM and soul?

It does increase the build time significantly but I don't think it's too
resource hungry. My desktop (AMD Ryzen 5 2600 w/ 16GB RAM) handles it fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux