https://bugzilla.redhat.com/show_bug.cgi?id=1670656 --- Comment #43 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- Hi Mark. Great, both for the patches and the test suite. Please add comments referencing the PRs for the patches once you have submitted them. Please file an issue upstream and reference it in the spec for the failing test. Use %global instead of %define in the following line: %define _debugsource_template %{nil} There's a typo in the tmpfs conf file creation, its content is likely invalid: {%GRAFANA_GROUP} --> %{GRAFANA_GROUP} A brp script is complaining: """ + /usr/lib/rpm/redhat/brp-mangle-shebangs BUILDSTDERR: *** WARNING: ./etc/grafana/ldap.toml is executable but has empty or no shebang, removing executable bit BUILDSTDERR: *** WARNING: ./etc/grafana/grafana.ini is executable but has empty or no shebang, removing executable bit BUILDSTDERR: *** WARNING: ./etc/sysconfig/grafana-server is executable but has empty or no shebang, removing executable bit BUILDSTDERR: *** WARNING: ./usr/share/grafana/conf/defaults.ini is executable but has empty or no shebang, removing executable bit """ Please fix the modes preferably in 003-file-mode-updates.patch and 004-grafana.ini-for-Linux-distros.patch or in %install. rpmlint doesn't catch this, because the brp script silently fixes it before. The unbundling of go packages should be done in %prep rather than %build. Same for the 2 hidden files removal. About unbundling, the more I look at the EL7 exception, the more I find it really ugly and likely does not conform to guidelines. Please remove the %if's around the go BuildRequires and the vendor dir cleaning, so they are always used. That way, it is not necessary to add back the 100+ lines of bundled go provides I wrote about in comment #39 and grafana can be built for EL7 once the missing golang packages are branched and built from Fedora. I have to check more closely, but the build is currently not using the Fedora flags. Sorry for not catching that earlier, because that is definitely not a minor point, despite what I wrote in comment #41. I think the upstream build script should not be used and the 2 binaries should be built using the %gobuild macro. After a bit of trial and error, something like that and a BR: compiler(go-compiler) works. %gobuild -o grafana-cli ./pkg/cmd/grafana-cli %gobuild -o grafana-server ./pkg/cmd/grafana-server This should allow to get rid of the arch symlinks at top of %install. Maybe that would also remove the need for %global _debugsource_template %{nil} ? Regards, Xavier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
