https://bugzilla.redhat.com/show_bug.cgi?id=1670656 --- Comment #40 from Lukas Berk <lberk@xxxxxxxxxx> --- Hi Xavier, (In reply to Xavier Bachelot from comment #39) > > > More nitpicking, you're used to it now ;-) > > > - Patch0 can probably be split in several pieces and part of them > > > upstream'ed (manpages and file perms changes at least seem relevant) > > > > OK, I've split into 3 patches (see comments in the spec) > > > 000-grafana-fedora.patch could be split again (Oauth / file perms). > The mostly noop 3rd part could be removed. > > 001-grafana-fedora.patch could also be split (distro defaults / manpages / > Specs + webpack). > > 002-grafana-fedora.patch looks ok. > > Also, the patches can probably use more descriptive names (eg. > grafana-6.1.3-fix_file_perms.patch, grafana-6.1.3-fix_oauth.patch, etc...) > Most of the patches (all but 002 ?) need to be submitted upstream and the > PR/issue URLs referenced in the specfile. > Upstream will likely want fine-grained commits, so the above patch split > will be needed anyway. I have to ask, as somebody looking forward to having grafana available as a properly packaged rpm in fedora, and considering the herculean effort Mark has put in here already, are these kind of patch tweaks/splits and bikeshedding on patch names really now the only blockers for getting grafana into fedora? Or are they things Mark can work on doing over time? I understand and emphatically agree with the notion of getting patches back upstream, but are we going to block Grafana's inclusion until they're accepted upstream? or can Mark take care of adjusting those patches when Grafana does a release and he updates the fedora packaged version to match? In other words, how much of a blocker is taking the one patch and splitting it into 5 (6?) really bringing to the state of the package, such that it's worth blocking the release over it? It'd be nice if we could set a concrete goal at what remains to be done for the fedora-review+ flag to be given, and not a constantly moving set of goalposts. Thanks for spending the time reviewing the work. Looking forward to being able to run grafana through the proper channels! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
