Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: twitux - a Twitter client for the Gnome desktop https://bugzilla.redhat.com/show_bug.cgi?id=307791 ------- Additional Comments From michel.sylvan@xxxxxxxxx 2007-09-26 17:14 EST ------- APPROVED, with following notes: - Dependency on glib2-devel unnecessary (pulled in by libsexy-devel) - Requires(post), Requires(postun), %post and %postun also unnecessary - Connecting is misspelled in upstream code and translation, patch attached. Please apply and forward to upstream. MUST • rpmlint: OK • package name: OK • spec file name: OK • package guideline-compliant: OK • license complies with guidelines: OK • license field accurate: OK • license file not deleted: OK • spec in US English: OK • spec legible: OK • source matches upstream: OK • builds under >= 1 archs, others excluded: OK • build dependencies complete: OK* • locales handled using %find_lang: OK • no dupes in %files: OK • permission: OK • %clean RPM_BUILD_ROOT: OK • macros used consistently: OK • Package contains code: OK • desktop file uses desktop-file-install: OK* • clean buildroot before install: OK • filenames UTF-8: OK SHOULD • package build in mock on all architectures • package functioned as described: OK • require package not files: OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review