https://bugzilla.redhat.com/show_bug.cgi?id=1652036 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zebob.m@xxxxxxxxx | |) | --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- You didn't address several points of my review: - Why is there two Source now? Remove Source: cockpit-session-recording-%{version}.tar.gz - Since you tagged a release, this is not necessary anymore: %global commit ffeec0bd364f165c73e769587eadc11d5c56864b %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global snapshotdate 20190404 - Source0 should have a better name Source0: %url/archive/%{version}/%{name}-%{version}.tar.gz - %autosetup -n %{name}-%{commit} → %autosetup -n %{name}-%{version} - No: %define debug_package %{nil} Make your package noarch instead: BuildArch: noarch - Be more specific here: %{_datadir}/cockpit/session-recording %{_datadir}/metainfo/org.cockpit-project.session-recording.metainfo.xml - Validate the Appdata file https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage BuildRequires: libappstream-glib […] appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/*.appdata.xml - The description must be split onto multiple lines to stay below 80 characters per line - Please use a more descriptive summary -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
