https://bugzilla.redhat.com/show_bug.cgi?id=1698252 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-requires: perl(File::Temp) - t/run.t:77 perl(IPC::Open3) - t/00-compile.t:26 perl(lib) - t/run.t:6 $ rpm -qp --requires perl-Test-Data-Split-0.2.1-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(autodie) 1 perl(Carp) 1 perl(IO::All) 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(MooX) 1 perl(parent) 1 perl(strict) 1 perl(Test::Data::Split::Backend::Hash) 1 perl(:VERSION) >= 5.8.0 1 perl(warnings) FIX: Please add run-requires perl(List::MoreUtils) - lib/Test/Data/Split/Backend/Hash.pm:46 $ rpm -qp --provides perl-Test-Data-Split-0.2.1-1.fc31.noarch.rpm | sort | uniq -c 1 perl(Test::Data::Split) = 0.2.1 1 perl-Test-Data-Split = 0.2.1-1.fc31 1 perl(Test::Data::Split::Backend::Hash) = 0.2.1 1 perl(Test::Data::Split::Backend::ValidateHash) = 0.2.1 Binary provides are Ok. $ rpmlint ./perl-Test-Data-Split* perl-Test-Data-Split.noarch: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization perl-Test-Data-Split.src: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok TODO: If you add to command './Build install' option --create_packlist=0 then you can remove the find command for removing packlist files and BR findutils. Please correct all 'FIX' issues and consider fixing 'TODO' items. Otherwise the package looks good. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
